PMD Results

The following document contains the results of PMD 6.0.1.

Files

ABOS/Derby/AddCustomerController.java

Violation Line
Avoid unused private fields such as 'tPane'. 80
Avoid unused local variables such as 'i'. 241
Avoid unused local variables such as 'i'. 317
Useless parentheses. 460
These nested if statements could be combined 464467
Useless parentheses. 489
Useless parentheses. 489
Useless parentheses. 534
Useless parentheses. 534
Useless parentheses. 536
Useless parentheses. 536
Useless parentheses. 550
Useless parentheses. 550
Useless parentheses. 562
Useless parentheses. 568

ABOS/Derby/AddCustomerWorker.java

Violation Line
Avoid unused private methods such as 'IntegerLength(int)'. 83
Avoid unused local variables such as 'numRows'. 126

ABOS/Derby/AddYearController.java

Violation Line
Avoid unused method parameters such as 'event'. 90
Avoid unused private methods such as 'tableFrmXML(ActionEvent)'. 90
Avoid unused method parameters such as 'event'. 210
Avoid unused private methods such as 'csvToXml(ActionEvent)'. 210
Avoid unused method parameters such as 'event'. 305
Avoid unused method parameters such as 'event'. 422
Avoid unused private methods such as 'addBtnPressed(ActionEvent)'. 422
Avoid unused local variables such as 'count'. 423
Avoid unused private methods such as 'submit(ActionEvent)'. 429
Avoid unused method parameters such as 'event'. 429
Avoid unused method parameters such as 'event'. 448
Avoid unused private methods such as 'cancel(ActionEvent)'. 448
Avoid unused local variables such as 'i'. 765
Avoid unused method parameters such as 'event'. 778
Avoid unused private methods such as 'tablefromDb(ActionEvent)'. 778
Avoid unused private methods such as 'xmlFromTable(ActionEvent)'. 784
Avoid unused method parameters such as 'event'. 784

ABOS/Derby/Customer.java

Violation Line
Useless parentheses. 288
Useless parentheses. 292
Useless parentheses. 294
Useless parentheses. 295
Useless parentheses. 296
Useless parentheses. 297
Useless parentheses. 298
Useless parentheses. 299
Useless parentheses. 345
Useless parentheses. 345
Useless parentheses. 355
Useless parentheses. 355
Useless parentheses. 357
Useless parentheses. 357
Useless parentheses. 374
Useless parentheses. 374

ABOS/Derby/CustomerController.java

Violation Line
Avoid unused local variables such as 'i'. 133
Useless parentheses. 156
Useless parentheses. 157
Avoid unused method parameters such as 'event'. 162
Avoid unused private methods such as 'deleteCustomer(ActionEvent)'. 162
Avoid unused private methods such as 'getNoMulchOrdered()'. 174
Useless parentheses. 177
Useless parentheses. 177
Avoid unused private methods such as 'getNoLivePlantsOrdered()'. 189
Avoid unused private methods such as 'getNoLawnProductsOrdered()'. 204
Avoid unused private methods such as 'getCommission(BigDecimal)'. 220
Useless parentheses. 222
Useless parentheses. 222
Useless parentheses. 224
Useless parentheses. 224

ABOS/Derby/DbInt.java

Violation Line
Useless parentheses. 125
Useless parentheses. 125126
Useless parentheses. 126
Useless parentheses. 181
Useless parentheses. 181182
Useless parentheses. 182

ABOS/Derby/Main.java

Violation Line
Avoid unused private fields such as 'selectNav'. 48
Avoid unused local variables such as 'controller'. 97
These nested if statements could be combined 111121
Avoid unused private methods such as 'updateSelectedItem(Object)'. 161
Avoid unused method parameters such as 'newValue'. 161

ABOS/Derby/MainController.java

Violation Line
Useless parentheses. 117
Useless parentheses. 128
Avoid unused local variables such as 'newPane'. 142
Avoid unused local variables such as 'loader'. 143
Avoid unused local variables such as 'finalNewPane'. 144
Useless parentheses. 169
Useless parentheses. 182
Useless parentheses. 194
Useless parentheses. 230
Useless parentheses. 244
Useless parentheses. 257
Useless parentheses. 296
Useless parentheses. 309
Useless parentheses. 322
Useless parentheses. 349
Useless parentheses. 362
Useless parentheses. 375

ABOS/Derby/MapController.java

Violation Line
Avoid unused private fields such as 'button'. 52
Avoid unused local variables such as 'Ord'. 81
Avoid unused local variables such as 'NI'. 82
Avoid unused local variables such as 'NH'. 83
Avoid unused local variables such as 'NI'. 144
Avoid unused local variables such as 'NH'. 146
Useless parentheses. 185

ABOS/Derby/Order.java

Violation Line
Useless parentheses. 54
Avoid unused local variables such as 'OrderID'. 202
Useless parentheses. 228
Useless parentheses. 228

ABOS/Derby/ReportsController.java

Violation Line
Avoid unused private fields such as 'cancelButton'. 95
Avoid unused private fields such as 'categoryPane'. 97
Avoid unused private methods such as 'getCityState(String)'. 185
Avoid unused private methods such as 'reportTypeChange(ActionEvent)'. 261
Avoid unused private methods such as 'selectedYearChanged(ActionEvent)'. 271
Avoid unused method parameters such as 'actionEvent'. 271
These nested if statements could be combined 276286
Avoid unused method parameters such as 'actionEvent'. 291
Avoid unused private methods such as 'selectedCategoryChanged(ActionEvent)'. 291
Useless parentheses. 417
These nested if statements could be combined 421424

ABOS/Derby/ReportsWorker.java

Violation Line
Useless parentheses. 202
Useless parentheses. 284
Useless parentheses. 515
Useless parentheses. 573
Useless parentheses. 629
Useless parentheses. 704
Avoid unused local variables such as 'yearObj'. 708
Useless parentheses. 794

ABOS/Derby/SettingsController.java

Violation Line
Avoid unused private methods such as 'getCityState(String)'. 396

ABOS/Derby/Year.java

Violation Line
Useless parentheses. 145
Useless parentheses. 147
Useless parentheses. 148
Useless parentheses. 149
Useless parentheses. 150
Useless parentheses. 151
Useless parentheses. 152
Useless parentheses. 229
Useless parentheses. 229

ABOS/Derby/YearController.java

Violation Line
Avoid unused local variables such as 'East'. 77
Avoid unused local variables such as 'i'. 131

Controllers/AddCustomerController.java

Violation Line
Avoid unused private fields such as 'okButton'. 91
Avoid unused private fields such as 'tPane'. 96
Avoid unused private fields such as 'preEditOrderCost'. 103
Avoid unused local variables such as 'preEditDonations'. 185
Avoid unused local variables such as 'i'. 386
Useless parentheses. 409
Useless parentheses. 522
Avoid unused local variables such as 'i'. 544
Avoid unused local variables such as 'preEditMulchSales'. 608
Avoid unused local variables such as 'preEditLawnProductSales'. 609
Avoid unused local variables such as 'preEditLivePlantSales'. 610
Avoid unused local variables such as 'newPane'. 674
Useless parentheses. 706
These nested if statements could be combined 710713
Useless parentheses. 734
Useless parentheses. 734
Avoid unused private methods such as 'getCommission(BigDecimal)'. 777
Useless parentheses. 779
Useless parentheses. 779
Useless parentheses. 781
Useless parentheses. 781
Useless parentheses. 795
Useless parentheses. 795
Useless qualified this usage in the same class. 892
Useless qualified this usage in the same class. 893

Controllers/AddUserController.java

Violation Line
Avoid unused private fields such as 'parentWindow'. 58
Avoid unused private methods such as 'cancel(ActionEvent)'. 78
Avoid unused method parameters such as 'event'. 78
Avoid unused method parameters such as 'event'. 93
Avoid unused private methods such as 'submit(ActionEvent)'. 93
Avoid unused local variables such as 'yearUsers'. 110
Avoid unused private methods such as 'deleteUser(ActionEvent)'. 141
Avoid unused method parameters such as 'event'. 141
Avoid unused local variables such as 'returnGroup'. 147
Avoid unused private methods such as 'addUser()'. 281

Controllers/AddYearController.java

Violation Line
Avoid unused private methods such as 'tableFrmXML(ActionEvent)'. 91
Avoid unused method parameters such as 'event'. 91
Avoid unused method parameters such as 'event'. 211
Avoid unused private methods such as 'csvToXml(ActionEvent)'. 211
Avoid unused method parameters such as 'event'. 306
Avoid unused method parameters such as 'event'. 428
Avoid unused private methods such as 'addBtnPressed(ActionEvent)'. 428
Avoid unused local variables such as 'count'. 429
Avoid unused private methods such as 'submit(ActionEvent)'. 435
Avoid unused method parameters such as 'event'. 435
Avoid unused method parameters such as 'event'. 454
Avoid unused private methods such as 'cancel(ActionEvent)'. 454
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 473
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 473
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 478
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 478
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 521
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 521
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 526
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 526
Avoid unused local variables such as 'i'. 784
Avoid unused private methods such as 'tablefromDb(ActionEvent)'. 797
Avoid unused method parameters such as 'event'. 797
Avoid unused method parameters such as 'event'. 803
Avoid unused private methods such as 'xmlFromTable(ActionEvent)'. 803

Controllers/CustomerController.java

Violation Line
Avoid unused local variables such as 'i'. 182
Useless parentheses. 205
Useless parentheses. 206
Avoid unused method parameters such as 'event'. 212
Avoid unused private methods such as 'deleteCustomer(ActionEvent)'. 212
Avoid unused private methods such as 'getNoMulchOrdered()'. 224
Useless parentheses. 227
Useless parentheses. 227
Avoid unused private methods such as 'getNoLivePlantsOrdered()'. 239
Avoid unused private methods such as 'getNoLawnProductsOrdered()'. 254
Avoid unused private methods such as 'getCommission(BigDecimal)'. 270
Useless parentheses. 272
Useless parentheses. 272
Useless parentheses. 274
Useless parentheses. 274

Controllers/MainController.java

Violation Line
Avoid unused private fields such as 'isAdmin'. 76
Avoid unused private fields such as 'namePane'. 78
Avoid unused private fields such as 'sidePane'. 80
Useless parentheses. 270
Useless parentheses. 283
Useless parentheses. 301
Avoid unused local variables such as 'newPane'. 329
Avoid unused local variables such as 'loader'. 330
Avoid unused local variables such as 'finalNewPane'. 331
Useless parentheses. 352
Useless parentheses. 367
Useless parentheses. 381
Useless parentheses. 406
Useless parentheses. 420
Useless parentheses. 433
Useless parentheses. 484
Useless parentheses. 497
Useless parentheses. 510
Useless parentheses. 530
Useless parentheses. 543
Useless parentheses. 556
Useless parentheses. 583
Useless parentheses. 598
Useless parentheses. 613
Useless parentheses. 780
These nested if statements could be combined 784787

Controllers/MapController.java

Violation Line
Avoid unused private fields such as 'button'. 58
Avoid unused local variables such as 'totLat'. 81
Avoid unused local variables such as 'ret'. 97
Avoid unused local variables such as 'Name'. 185
Avoid unused local variables such as 'PhoneD'. 191
Useless parentheses. 211
Avoid unused local variables such as 'PhoneD'. 230
Useless parentheses. 250
Avoid unused private methods such as 'getAllCustomersInfo(String)'. 318
Avoid unused private methods such as 'getCustInfo(String,String,String)'. 337
Useless parentheses. 376

Controllers/ReportsController.java

Violation Line
Avoid unused private fields such as 'cancelButton'. 99
Avoid unused private methods such as 'reportTypeChange(ActionEvent)'. 127
Avoid unused private methods such as 'selectedYearChanged(ActionEvent)'. 140
Avoid unused method parameters such as 'actionEvent'. 140
Avoid unused method parameters such as 'actionEvent'. 158
Avoid unused private methods such as 'selectedUserChanged(ActionEvent)'. 158
These nested if statements could be combined 182198
Avoid unused private methods such as 'selectedCustomerChanged(ActionEvent)'. 217
Avoid unused method parameters such as 'actionEvent'. 217
Avoid unused private methods such as 'selectedCategoryChanged(ActionEvent)'. 235
Avoid unused method parameters such as 'actionEvent'. 235
Useless parentheses. 344
These nested if statements could be combined 348351
Useless parentheses. 376
Useless parentheses. 418
These nested if statements could be combined 422425

Controllers/SettingsController.java

Violation Line
Avoid unused private methods such as 'verifyAdmin(ActionEvent)'. 211
Avoid unused method parameters such as 'event'. 211

Controllers/UsersGroupsAndYearsController.java

Violation Line
Avoid unused private fields such as 'selectedGroups'. 130
Avoid unused private fields such as 'groupPaneCheckboxes'. 132
Useless parentheses. 224
These nested if statements could be combined 228231
Avoid unused local variables such as 'yearObj'. 261
Avoid unused local variables such as 'pane'. 349
Avoid unused method parameters such as 'event'. 601
Avoid unused private methods such as 'addSelectedUsersToGroup(ActionEvent)'. 601
Unnecessary use of fully qualified name 'javafx.scene.Node' due to existing import 'javafx.scene.Node' 624
Avoid unused local variables such as 'alertDisabled'. 647
Avoid unused private methods such as 'unselectAllGroupUsers()'. 676
Avoid unused method parameters such as 'event'. 681
Avoid unused private methods such as 'disableSelectedUsers(ActionEvent)'. 681
Avoid unused local variables such as 'returnGroup'. 682
Useless parentheses. 697
Unnecessary use of fully qualified name 'javafx.scene.Node' due to existing import 'javafx.scene.Node' 708
Avoid unused private methods such as 'archiveSelectedUsers(ActionEvent)'. 747
Avoid unused method parameters such as 'event'. 747
Avoid unused local variables such as 'returnGroup'. 748
Useless parentheses. 763
Unnecessary use of fully qualified name 'javafx.scene.Node' due to existing import 'javafx.scene.Node' 774
Avoid unused method parameters such as 'event'. 816
Avoid unused private methods such as 'enableSelectedUsers(ActionEvent)'. 816
Avoid unused method parameters such as 'event'. 838
Avoid unused private methods such as 'addSelectedUsersToUser(ActionEvent)'. 838
Unnecessary use of fully qualified name 'javafx.scene.Node' due to existing import 'javafx.scene.Node' 860
Avoid unused local variables such as 'alertDisabled'. 883
Avoid unused private methods such as 'cancelUser(ActionEvent)'. 903
Avoid unused method parameters such as 'event'. 903
Avoid unused local variables such as 'returnGroup'. 908
Useless parentheses. 923
Unnecessary use of fully qualified name 'javafx.scene.Node' due to existing import 'javafx.scene.Node' 934
Avoid unused local variables such as 'returnGroup'. 970
Useless parentheses. 985
Unnecessary use of fully qualified name 'javafx.scene.Node' due to existing import 'javafx.scene.Node' 996
Avoid unused local variables such as 'oldUser'. 1031
Avoid unused local variables such as 'years'. 1093
Avoid unused local variables such as 'yearUsers'. 1106
Avoid unused private methods such as 'saveUsers(ActionEvent)'. 1125
Avoid unused method parameters such as 'event'. 1125
Avoid unused local variables such as 'yearUsers'. 1127
Avoid unused method parameters such as 'event'. 1167
Avoid unused private methods such as 'addSingleUser(ActionEvent)'. 1167
Unnecessary use of fully qualified name 'javafx.scene.Node' due to existing import 'javafx.scene.Node' 1198
Avoid unused local variables such as 'yearUsers'. 1251
Avoid unused private methods such as 'addBulkUsers(ActionEvent)'. 1261
Avoid unused method parameters such as 'event'. 1261
Avoid unused private methods such as 'addBulkGroups(ActionEvent)'. 1266
Avoid unused method parameters such as 'event'. 1266
Avoid unused method parameters such as 'event'. 1271
Avoid unused private methods such as 'addSingleGroup(ActionEvent)'. 1271
Avoid unused local variables such as 'newGroup'. 1272
Useless parentheses. 12721277
Avoid unused local variables such as 'newYear'. 1292
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 1313
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 1313
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 1325
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 1325
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 1337
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 1337
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 1349
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 1349
Avoid unused local variables such as 'unitPrice'. 1354
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 1374
Unnecessary use of fully qualified name 'javafx.scene.control.TableColumn' due to existing import 'javafx.scene.control.*' 1374
Avoid unused method parameters such as 'event'. 1394
Avoid unused private methods such as 'submit(ActionEvent)'. 1394
Avoid unused private methods such as 'tableFrmXML(ActionEvent)'. 1405
Avoid unused method parameters such as 'event'. 1405
Avoid unused private methods such as 'csvToXml(ActionEvent)'. 1525
Avoid unused method parameters such as 'event'. 1525
Unnecessary use of fully qualified name 'javafx.scene.Node' due to existing import 'javafx.scene.Node' 1583
Avoid unused method parameters such as 'event'. 1620
Unnecessary use of fully qualified name 'javafx.scene.Node' due to existing import 'javafx.scene.Node' 1647
Unnecessary use of fully qualified name 'javafx.scene.Node' due to existing import 'javafx.scene.Node' 1707
Avoid unused private methods such as 'addBtnPressed(ActionEvent)'. 1742
Avoid unused method parameters such as 'event'. 1742
Avoid unused local variables such as 'count'. 1743
Avoid unused local variables such as 'i'. 1955
Avoid unused method parameters such as 'event'. 1968
Avoid unused private methods such as 'tablefromDb(ActionEvent)'. 1968
Avoid unused method parameters such as 'event'. 1973
Avoid unused private methods such as 'xmlFromTable(ActionEvent)'. 1973
Avoid unused private methods such as 'arrayToCSV(Collection)'. 1988
Avoid unused local variables such as 'newPane'. 2003
Avoid unused local variables such as 'loader'. 2004
Avoid unused local variables such as 'finalNewPane'. 2005

Controllers/YearController.java

Violation Line
Avoid unused local variables such as 'East'. 89
Avoid unused local variables such as 'i'. 152

Launchers/ConvertDerbyToSQL.java

Violation Line
Avoid unused local variables such as 'yearUsers'. 96
Avoid unused local variables such as 'cID'. 149
Useless parentheses. 266
These nested if statements could be combined 270273

Launchers/Main.java

Violation Line
Avoid unused private fields such as 'selectNav'. 56
These nested if statements could be combined 120130
Avoid unused local variables such as 'masterStage'. 166
Avoid unused private methods such as 'updateSelectedItem(Object)'. 173
Avoid unused method parameters such as 'newValue'. 173

Utilities/Customer.java

Violation Line
Useless parentheses. 352
Useless parentheses. 352
Useless parentheses. 362
Useless parentheses. 362
Useless parentheses. 364
Useless parentheses. 364
Useless parentheses. 381
Useless parentheses. 381

Utilities/DbInt.java

Violation Line
Useless parentheses. 172
Useless parentheses. 172173
Useless parentheses. 173
Useless parentheses. 230
Useless parentheses. 351352
Useless parentheses. 351
Useless parentheses. 352
Useless parentheses. 399
Useless parentheses. 399400
Useless parentheses. 400
Useless parentheses. 561
Useless parentheses. 561562
Useless parentheses. 562
Useless parentheses. 639
Useless parentheses. 660

Utilities/Geolocation.java

Violation Line
Avoid unused private methods such as 'parseCoords(String)'. 231

Utilities/Group.java

Violation Line
Avoid unused local variables such as 'groupUsers'. 114
Useless parentheses. 288
Useless parentheses. 288
Useless parentheses. 288

Utilities/Order.java

Violation Line
Useless parentheses. 185
Useless parentheses. 185
Useless parentheses. 208
Useless parentheses. 208
Avoid unused private methods such as 'IntegerLength(int)'. 253
Useless parentheses. 322

Utilities/Settable.java

Violation Line
Useless parentheses. 34
Useless parentheses. 56
Useless parentheses. 93

Utilities/User.java

Violation Line
Avoid unused private fields such as 'ACL'. 34
Avoid unused local variables such as 'ret'. 69
Useless parentheses. 78
Avoid unused constructor parameters such as 'years'. 124

Utilities/Version.java

Violation Line
Useless parentheses. 59
Useless parentheses. 59
Useless parentheses. 71
Useless parentheses. 71
Useless parentheses. 71
Useless parentheses. 79
Useless parentheses. 79
Useless parentheses. 88
Useless parentheses. 95
Useless parentheses. 109
Useless parentheses. 109
Useless parentheses. 109

Utilities/Year.java

Violation Line
Useless parentheses. 141
Avoid unused private methods such as 'getTots(String,int)'. 667
Useless parentheses. 962
Useless parentheses. 962
Useless parentheses. 964
Useless parentheses. 964

Workers/AddCustomerWorker.java

Violation Line
Avoid unused private methods such as 'IntegerLength(int)'. 92
Avoid unused local variables such as 'numRows'. 135
Useless parentheses. 143145
Useless parentheses. 146148
Useless parentheses. 151153
Useless parentheses. 154156
Avoid unused local variables such as 'Id'. 157

Workers/LoadMainWorker.java

Violation Line
Avoid unused private methods such as 'failIfInterrupted()'. 47
Avoid unused private methods such as 'IntegerLength(int)'. 53
Avoid unused local variables such as 'userRoot'. 96

Workers/LoadUGYWorker.java

Violation Line
Avoid unused private methods such as 'failIfInterrupted()'. 50
Avoid unused private methods such as 'IntegerLength(int)'. 56
Avoid unused local variables such as 'year'. 117
Avoid unused local variables such as 'curUser'. 118

Workers/ReportsWorker.java

Violation Line
Useless parentheses. 214
Useless parentheses. 297
Useless parentheses. 541
Useless parentheses. 599
Useless parentheses. 690
Useless parentheses. 888

Workers/orderHistoryReportWorker.java

Violation Line
Avoid unused private methods such as 'getProg()'. 129
Avoid unused private methods such as 'setProgress(double)'. 133

addFlyWay.java

Violation Line
These nested if statements could be combined 3640